linux-ext4 - Re: avoid leak upon failed realloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070622064144.GC17097@thunk.org>
Date:	Fri, 22 Jun 2007 02:41:44 -0400
From:	Theodore Tso <tytso@....edu>
To:	Jim Meyering <jim@...ering.net>
Cc:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>,
	linux-ext4@...r.kernel.org, samba-technical@...ts.samba.org
Subject: Re: avoid leak upon failed realloc

On Mon, Jun 18, 2007 at 04:10:44PM +0200, Jim Meyering wrote:
> Here's a tiny fix to avoid a leak when realloc fails:
> 
> 2007-06-16  Jim Meyering  <jim@...ering.net>
> 
> 	* tdb.c (tdb_append): Don't leak a buffer when realloc fails.

Hi Jim,

	Thanks for the patch!  I actually automatically build the
tdb.c file from the Samba SVN tree (with a series of patches and
scripts) at: 

	svn://svnanon.samba.org/samba/branches/SAMBA_4_0/source/lib/tdb

So I'm going to forward this patch (attached) to the Samba developers.
It appears to apply cleanly to .../source/lib/tdb/common/tdb.c.  Once
they commit it into their SVN tree, I can just pick it up from there.

Regards,

						- Ted


View attachment "tdb-patch" of type "text/plain" (1265 bytes)