lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 22 Jun 2007 10:27:04 -0700
From:	Jeremy Allison <jra@...ba.org>
To:	Theodore Tso <tytso@....edu>
Cc:	Jim Meyering <jim@...ering.net>, samba-technical@...ts.samba.org,
	linux-ext4@...r.kernel.org,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
Subject: Re: avoid leak upon failed realloc

On Fri, Jun 22, 2007 at 02:41:44AM -0400, Theodore Tso wrote:
> On Mon, Jun 18, 2007 at 04:10:44PM +0200, Jim Meyering wrote:
> > Here's a tiny fix to avoid a leak when realloc fails:
> > 
> > 2007-06-16  Jim Meyering  <jim@...ering.net>
> > 
> > 	* tdb.c (tdb_append): Don't leak a buffer when realloc fails.
> 
> Hi Jim,
> 
> 	Thanks for the patch!  I actually automatically build the
> tdb.c file from the Samba SVN tree (with a series of patches and
> scripts) at: 
> 
> 	svn://svnanon.samba.org/samba/branches/SAMBA_4_0/source/lib/tdb
> 
> So I'm going to forward this patch (attached) to the Samba developers.
> It appears to apply cleanly to .../source/lib/tdb/common/tdb.c.  Once
> they commit it into their SVN tree, I can just pick it up from there.

Thanks Ted, we fixed this in the generic Samba sources by using
realloc wrappers, but tdb has to be separate from these.

I'll commit the fix asap.

Thanks,

	Jeremy.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists