[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070623003646.GD22889@thunk.org>
Date: Fri, 22 Jun 2007 20:36:47 -0400
From: Theodore Tso <tytso@....edu>
To: Kalpak Shah <kalpak@...sterfs.com>
Cc: linux-ext4 <linux-ext4@...r.kernel.org>,
Andreas Dilger <adilger@...sterfs.com>
Subject: Re: [PATCH] Endianness bugs in e2fsck
On Wed, Jun 20, 2007 at 03:03:08PM +0530, Kalpak Shah wrote:
> In ext2fs_swap_inode_full() only the first (GOOD_OLD_INODE_SIZE +
> i_extra_isize)bytes are copied into inode. The rest of the inode is
> not zeroed. So memset the inode to zero if swapfs is enabled.
This was due to the bug where we weren't dealing with the i_extra_size
correctly, right? ext2fs_swap_inode_full *should* be swapping the
extra fields and copying it into the inode. If not, that's should be
the real bug, and adding the memset(inode, 0, bufset) doesn't seem to
be useful.
Am I missing something?
- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists