linux-ext4 - Re: [PATCH] Endianness bugs in e2fsck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070623023414.GE22889@thunk.org>
Date:	Fri, 22 Jun 2007 22:34:15 -0400
From:	Theodore Tso <tytso@....edu>
To:	Kalpak Shah <kalpak@...sterfs.com>
Cc:	linux-ext4 <linux-ext4@...r.kernel.org>,
	Andreas Dilger <adilger@...sterfs.com>
Subject: Re: [PATCH] Endianness bugs in e2fsck

Also applied into the e2fsprogs tree.

					- Ted

# HG changeset patch
# User tytso@....edu
# Date 1182565963 14400
# Node ID 98d5fa14e7dedde4754cd42f4d2af2622c4ba3ee
# Parent  deeb424beb36d9fb1ff401aca7a5761a451436b8
Fix ext2fs_read_inode_full() so that the whole inode is byte-swapped

Signed-off-by: Kalpak Shah <kalpak@...sterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@....edu>

diff -r deeb424beb36 -r 98d5fa14e7de lib/ext2fs/ChangeLog
--- a/lib/ext2fs/ChangeLog	Fri Jun 22 19:53:21 2007 -0400
+++ b/lib/ext2fs/ChangeLog	Fri Jun 22 22:32:43 2007 -0400
@@ -1,4 +1,7 @@ 2007-06-22  Theodore Tso  <tytso@....edu
 2007-06-22  Theodore Tso  <tytso@....edu>
+
+	* inode.c (ext2fs_read_inode_full): Pass in bufsize so the full
+		inode is byte-swapped.
 
 	* swapfs.c (ext2fs_swap_inode_full): Fix byte-swapping issues for
 		i_extra_size field.
diff -r deeb424beb36 -r 98d5fa14e7de lib/ext2fs/inode.c
--- a/lib/ext2fs/inode.c	Fri Jun 22 19:53:21 2007 -0400
+++ b/lib/ext2fs/inode.c	Fri Jun 22 22:32:43 2007 -0400
@@ -586,7 +586,7 @@ errcode_t ext2fs_read_inode_full(ext2_fi
 	    (fs->flags & EXT2_FLAG_SWAP_BYTES_READ))
 		ext2fs_swap_inode_full(fs, (struct ext2_inode_large *) inode, 
 				       (struct ext2_inode_large *) inode, 
-				       0, length);
+				       0, bufsize);
 #endif
 
 	/* Update the inode cache */
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html