[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4680F273.3080809@bull.net>
Date: Tue, 26 Jun 2007 13:03:15 +0200
From: Valerie Clement <valerie.clement@...l.net>
To: Girish Shilamkar <girish@...sterfs.com>
Cc: Alex Tomas <alex@...sterfs.com>,
Andreas Dilger <adilger@...sterfs.com>,
ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: performance testing
Girish Shilamkar wrote:
> On Tue, 2007-06-26 at 11:48 +0200, Valerie Clement wrote:
>> Shouldn't it be :
>>
>> struct commit_header *tmp = (struct commit_header*)(bh->b_data + i);
>>
> Ohhh, yes you are right. This is the correct thing to do.
> This patch which is been used has some endian-ness bugs. I had sent an
> updated patch for 2.6.22-rc5 on
> 19 June. I think we should be using the updated patch else it may break
> on big-endian machines.
> Even the updated patch has this bug i.e "struct commit_header *tmp
> =...."
>
> Thanks,
> Girish.
>
Hi Girish,
I made the change on my system and tested it. Good news, everything
seems to work well now. Could you please make and post the patch?
Thanks,
Valérie
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists