linux-ext4 - Re: [PATCH 1/3] ext2: show all mount options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070723232110.GE30165@thunk.org>
Date:	Mon, 23 Jul 2007 19:21:10 -0400
From:	Theodore Tso <tytso@....edu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Miklos Szeredi <miklos@...redi.hu>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/3] ext2: show all mount options

On Mon, Jul 23, 2007 at 01:56:42PM -0700, Andrew Morton wrote:
> On Mon, 23 Jul 2007 22:12:54 +0200
> Miklos Szeredi <miklos@...redi.hu> wrote:
> 
> > From: Miklos Szeredi <mszeredi@...e.cz>
> > 
> > Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>
> 
> Could we have changelogs for these patches, please?
> 
> ie: what's wrong with the existing code, what change does this patch make?

The idea is to allow /proc/mounts to display all of the mount options
that were used to mount a particular filesystem.  This is useful if
you want /proc/mounts to replace /etc/mtab.

I keep thinking that this is really the wrong approach, though, since
it means adding a lot of coding to every single filesystem to
reconstruct the mount options, and in some cases it will still never
be enough to reconstruct exactly what was in /etc/mtab.  (For example,
the fully qualified domain named passed into some remote filesystem.)

It seems to me the right answer would be to enhance the mount(2)
system call with a new mount operation which would allow the user
space mount command can stash exactly the options used to mount the
filesystem.  That we the kernel can store the exact ascii string in
allocated memory and regurgitate it for the benefit of /proc/mounts,
instead of adding a lot of code into ext2, ext3, ext4, et. al in an
attempt partially reconstruct the mount options.  

						- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html