linux-ext4 - Re: e2fsprogs patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070801230513.GD5692@schatzie.adilger.int>
Date:	Wed, 1 Aug 2007 17:05:13 -0600
From:	Andreas Dilger <adilger@...sterfs.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: e2fsprogs patches

On Aug 01, 2007  21:04 +0530, Aneesh Kumar K.V wrote:
> Regarding the naming of tdb file i decided to go with
> mke2fs-<device_name> instead of mke2fs-<device_name>-<time-stamp>.
> I guess having multiple version of this file in the tdb_dir will confuse
> the user.

I thought about this also - it might make sense to allow multiple undo
files if e.g. e2fsck is run several times in a row, and the user doesn't
like the outcome.  I think this also means that we should call the files
"undoe2fs-*" as having undo files for e2fsck is probably desirable.

I guess that also suggests we should save the s_lastcheck (last e2fsck)
time into the tdb, so we can be sure to undo them in the right order.

As for putting them into /var/lib/e2fsprogs, it might make sense to put
them into /var/tmp/e2fsprogs instead, because the files will be obsolete
as soon as the filesystem is mounted...  Alternately, e2fsprogs should
install something like /etc/cron.daily/e2fsprogs to clean up
/var/lib/e2fsprogs in a timely manner, like:

	tmpwatch -m 128 -d /var/lib/e2fsprogs

I also looked at logrotate, but it uses a fixed filename instead of
a regexp.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html