linux-ext4 - Re: [PATCH 1/4] e2fsprogs: Add undo I/O manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070801225247.GC5692@schatzie.adilger.int>
Date:	Wed, 1 Aug 2007 16:52:47 -0600
From:	Andreas Dilger <adilger@...sterfs.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/4] e2fsprogs: Add undo I/O manager

On Aug 01, 2007  21:04 +0530, Aneesh Kumar K.V wrote:
> +static errcode_t write_file_system_identity(io_channel undo_channel,
> +							TDB_CONTEXT *tdb)
> +{
> +	/* Write to tdb file in the file system byte order */
> +	tdb_key.dptr = "filesystem MTIME";
> +	tdb_key.dsize = sizeof("filesystem MTIME");
> +	tdb_data.dptr = (unsigned char *) &(super.s_mtime);
> +	tdb_data.dsize = sizeof(super.s_mtime);
> +
> +	tdb_key.dptr = "filesystem UUID";
> +	tdb_key.dsize = sizeof("filesystem UUID");
> +	tdb_data.dptr = (unsigned char *)&(super.s_uuid);
> +	tdb_data.dsize = sizeof(super.s_uuid);

Is this the mtime and UUID of the new filesystem or the old one?  It
should be the UUID and mtime of the new filesystem, so that the
undo file can be verified against the current superblock.  This poses
a bit of a problem, because that information isn't saved until after
the mke2fs run is finished.

One possibility is to overwrite this information at the end of mke2fs
after the new UUID and mtime are written?

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html