linux-ext4 - Re: Avoid rec_len overflow with 64KB block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070920161722.GE1986@atrey.karlin.mff.cuni.cz>
Date:	Thu, 20 Sep 2007 18:17:22 +0200
From:	Jan Kara <jack@...e.cz>
To:	linux-ext4@...r.kernel.org
Subject: Re: Avoid rec_len overflow with 64KB block size

>   when converting ext4 directories to pagecache I just came over
> Takashi's patch preventing overflowing of rec_len. Looking over the
> patch - can't we do it more elegantly by using say 0xffff instead of 64K
> and perform conversion (using some helper) at the moment we read / store
> rec_len? That would be IMHO more transparent than current approach (at
> least it took me some time to understand what's going on with the
> current patch when I was looking at the code)...
  Attached is a patch that does this for ext4. If you like this
approach, I can cook up a similar patch for ext2 / ext3.

									Honza
-- 
Jan Kara <jack@...e.cz>
SuSE CR Labs

View attachment "ext4-2.6.23-rc6-ext4_64k_blocksize.diff" of type "text/x-diff" (11688 bytes)