[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070920143214.GC1986@atrey.karlin.mff.cuni.cz>
Date: Thu, 20 Sep 2007 16:32:14 +0200
From: Jan Kara <jack@...e.cz>
To: linux-ext4@...r.kernel.org
Cc: Takashi Sato <sho@...s.nec.co.jp>
Subject: Avoid rec_len overflow with 64KB block size
Hello,
when converting ext4 directories to pagecache I just came over
Takashi's patch preventing overflowing of rec_len. Looking over the
patch - can't we do it more elegantly by using say 0xffff instead of 64K
and perform conversion (using some helper) at the moment we read / store
rec_len? That would be IMHO more transparent than current approach (at
least it took me some time to understand what's going on with the
current patch when I was looking at the code)...
Honza
--
Jan Kara <jack@...e.cz>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists