lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080124052907.GB7902@skywalker> Date: Thu, 24 Jan 2008 10:59:07 +0530 From: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: "Theodore Ts'o" <tytso@....EDU>, linux-kernel@...r.kernel.org, Andy Whitcroft <apw@...dowen.org>, "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org> Subject: Re: [PATCH 30/49] ext4: Convert truncate_mutex to read write semaphore. On Wed, Jan 23, 2008 at 02:06:59PM -0800, Andrew Morton wrote: > > On Mon, 21 Jan 2008 22:02:09 -0500 "Theodore Ts'o" <tytso@....EDU> wrote: > > +int ext4_get_blocks_wrap(handle_t *handle, struct inode *inode, sector_t block, > > + unsigned long max_blocks, struct buffer_head *bh, > > + int create, int extend_disksize) > > +{ > > + int retval; > > + if (create) { > > + down_write((&EXT4_I(inode)->i_data_sem)); > > + } else { > > + down_read((&EXT4_I(inode)->i_data_sem)); > > + } > > + if (EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) { > > + retval = ext4_ext_get_blocks(handle, inode, block, max_blocks, > > + bh, create, extend_disksize); > > + } else { > > + retval = ext4_get_blocks_handle(handle, inode, block, > > + max_blocks, bh, create, extend_disksize); > > + } > > + if (create) { > > + up_write((&EXT4_I(inode)->i_data_sem)); > > + } else { > > + up_read((&EXT4_I(inode)->i_data_sem)); > > + } > > This function has many unneeded braces. checkpatch used to detect this > but it seems to have broken. The follow up patch "ext4: Take read lock during overwrite case" removes those single line if statement. > > > + return retval; > > +} > > static int ext4_get_block(struct inode *inode, sector_t iblock, > > struct buffer_head *bh_result, int create) > > Mising newline. Fixed. -aneesh - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists