lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20080123140659.5b70ae6b.akpm@linux-foundation.org> Date: Wed, 23 Jan 2008 14:06:59 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: "Theodore Ts'o" <tytso@....EDU> Cc: linux-kernel@...r.kernel.org, aneesh.kumar@...ux.vnet.ibm.com, Andy Whitcroft <apw@...dowen.org>, "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org> Subject: Re: [PATCH 30/49] ext4: Convert truncate_mutex to read write semaphore. > On Mon, 21 Jan 2008 22:02:09 -0500 "Theodore Ts'o" <tytso@....EDU> wrote: > +int ext4_get_blocks_wrap(handle_t *handle, struct inode *inode, sector_t block, > + unsigned long max_blocks, struct buffer_head *bh, > + int create, int extend_disksize) > +{ > + int retval; > + if (create) { > + down_write((&EXT4_I(inode)->i_data_sem)); > + } else { > + down_read((&EXT4_I(inode)->i_data_sem)); > + } > + if (EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) { > + retval = ext4_ext_get_blocks(handle, inode, block, max_blocks, > + bh, create, extend_disksize); > + } else { > + retval = ext4_get_blocks_handle(handle, inode, block, > + max_blocks, bh, create, extend_disksize); > + } > + if (create) { > + up_write((&EXT4_I(inode)->i_data_sem)); > + } else { > + up_read((&EXT4_I(inode)->i_data_sem)); > + } This function has many unneeded braces. checkpatch used to detect this but it seems to have broken. > + return retval; > +} > static int ext4_get_block(struct inode *inode, sector_t iblock, > struct buffer_head *bh_result, int create) Mising newline. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists