lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20080123140716.e6f5d14f.akpm@linux-foundation.org> Date: Wed, 23 Jan 2008 14:07:16 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: "Theodore Ts'o" <tytso@....EDU> Cc: linux-kernel@...r.kernel.org, aneesh.kumar@...ux.vnet.ibm.com, "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org> Subject: Re: [PATCH 36/49] ext4: Add EXT4_IOC_MIGRATE ioctl > On Mon, 21 Jan 2008 22:02:15 -0500 "Theodore Ts'o" <tytso@....EDU> wrote: > The below patch add ioctl for migrating ext3 indirect block mapped inode > to ext4 extent mapped inode. This patch adds lots of weird and inexplicable single- and double-newlines in inappropriate places. However it frequently forgets to add newlines between end-of-locals and start-of-code, which is usual practice. +struct list_blocks_struct { + ext4_lblk_t first_block, last_block; + ext4_fsblk_t first_pblock, last_pblock; +}; This structure would benefit from some code comments. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists