linux-ext4 - Re: Entries in feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <20080413034957.GA8058@webber.adilger.int>
Date:	Sat, 12 Apr 2008 21:49:57 -0600
From:	Andreas Dilger <adilger@....com>
To:	Girish Shilamkar <Girish.Shilamkar@....com>
Cc:	Ext4 Mailing List <linux-ext4@...r.kernel.org>,
	Theodore Tso <tytso@....edu>
Subject: Re: Entries in feature_list[]

On Mar 27, 2008  13:10 +0530, Girish Shilamkar wrote:
> In e2fsprogs/lib/e2p/feature.c 
> struct feature feature_list[] contains:
>         ... 
> 	{       E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS,
>                         "extents" },
>         {       E2P_FEATURE_INCOMPAT, EXT2_FEATURE_INCOMPAT_META_BG,
>                         "meta_bg" }
>         {       E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS,
>                         "extent" },
>         ...
> 
> Is the { E2P_*, EXT3_*, "extent"} entry correct one, if yes, what is the purpose behind having two
> {E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS, *} entries, unless we want "extent" to be 
> correct feature ?

This is probably a merge error, or maybe a convenice measure to allow both
"extent" and "extents"?  We need something similar for "uninit_groups"
and the new "uninit_bg".

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html