linux-ext4 - Re: [PATCH] ext3 : Remove redundant condition in ext3_free_blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080531190527.GG28946@ZenIV.linux.org.uk>
Date:	Sat, 31 May 2008 20:05:27 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Manish Katiyar <mkatiyar@...il.com>
Cc:	linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ext3 : Remove redundant condition in
	ext3_free_blocks_sb()

On Sun, Jun 01, 2008 at 12:26:41AM +0530, Manish Katiyar wrote:
> For two unsigned values the check "block+count < block"  is always
> false. Thus the below patch removes that condition.

Really?  Always?

	unsigned block = 1;
	unsigned count = ~0U;

What will be the value and type of block + count?  What will be the
value of block + count < block?
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html