linux-ext4 - Re: [PATCH] ext3 : Remove redundant condition in ext3_free_blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea11fea30805311210o15de2373m71d91228356f9bfd@mail.gmail.com>
Date:	Sun, 1 Jun 2008 00:40:32 +0530
From:	"Manish Katiyar" <mkatiyar@...il.com>
To:	"Al Viro" <viro@...iv.linux.org.uk>
Cc:	linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ext3 : Remove redundant condition in ext3_free_blocks_sb()

On Sun, Jun 1, 2008 at 12:35 AM, Al Viro <viro@...iv.linux.org.uk> wrote:
> On Sun, Jun 01, 2008 at 12:26:41AM +0530, Manish Katiyar wrote:
>> For two unsigned values the check "block+count < block"  is always
>> false. Thus the below patch removes that condition.
>
> Really?  Always?
>
>        unsigned block = 1;
>        unsigned count = ~0U;
>
> What will be the value and type of block + count?  What will be the
> value of block + count < block?

Oooops....my bad, but I doubt if we pass such values in ext* code anywhere.

>



-- 
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html