linux-ext4 - Re: [RFC][PATCH 4/6] delalloc ENOSPC: avoid free blocks double booking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Jun 2008 00:12:36 -0700
From:	Mingming Cao <cmm@...ibm.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [RFC][PATCH 4/6] delalloc ENOSPC: avoid free blocks  double
	booking

On Mon, 2008-06-02 at 12:21 +0530, Aneesh Kumar K.V wrote:
> On Sun, Jun 01, 2008 at 04:36:10PM -0700, Mingming Cao wrote:
> > ext4: delalloc block reservation avoid double accounting
> > 
> > From: Mingming cao <cmm@...ibm.com>
> > 
> > Since fs free blocks counters are already reduced at the block reservation
> > time, we need to let the underlying block allocation know to avoid
> > decrease the free blocks counter again when real block allocation finished.
> > 
> > Signed-off-by: Mingming cao <cmm@...ibm.com>
> > ---
> >  fs/ext4/dir.c     |    3 ++-
> >  fs/ext4/ext4.h    |    6 +++++-
> >  fs/ext4/ext4_i.h  |    1 +
> >  fs/ext4/extents.c |    2 +-
> >  fs/ext4/inode.c   |   25 ++++++++++++++++++-------
> >  fs/ext4/mballoc.c |   13 ++++++++++++-
> >  fs/ext4/super.c   |    2 ++
> >  7 files changed, 41 insertions(+), 11 deletions(-)
> > 
> 
> I guess you would need a similar change for balloc.c 
> 

I haven't try delaloc on non-extent files yet. that's todo after this
series is settle down. 

It first need a similar function to calculate the total number of meta
data blocks to reserve for non extent files, then similar accounting
handling for balloc.

Mingming

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html