linux-ext4 - Re: [PATCH] ext4: Fix use of uninitialized data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Jun 2008 09:23:32 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
CC:	Theodore Tso <tytso@....edu>, cmm@...ibm.com,
	linux-ext4@...r.kernel.org, alex@...sterfs.com, adilger@....com
Subject: Re: [PATCH] ext4: Fix use of uninitialized data

Aneesh Kumar K.V wrote:
> On Mon, Jun 02, 2008 at 08:42:24AM -0500, Eric Sandeen wrote:

>> so it's fine... but why are we carrying around a field in the sbi to
>> hold a constant that cannot be changed runtime?
> 
> We can tune that via MB_PROC_FOPS(group_prealloc);

MB_PROC_VALUE_WRITE()....

ah, cleverly hidden from cscope with a macro.  :)

Ok, so technically then this could be big enough to overflow fe_len:

        value = simple_strtol(str, NULL, 0);                    \
        if (value <= 0)                                         \
                return -ERANGE;                                 \
        sbi->s_mb_##name = value;                               \


but I guess it's probably not the first thing we need to worry about.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html