linux-ext4 - Re: [RFC][PATCH 6/6] delalloc ENOSPC: improve percpu counter accounting accurate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 01 Jun 2008 19:30:25 -0700
From:	Mingming Cao <cmm@...ibm.com>
To:	Akira Fujita <a-fujita@...jp.nec.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [RFC][PATCH 6/6] delalloc ENOSPC: improve percpu
	counter	accounting accurate

On Mon, 2008-06-02 at 09:19 +0900, Akira Fujita wrote:
> Hi,
> 
> > Mingming Cao wrote:
> > percpu counter: update center counter when sum per-cpu counter
> >
> > From: Mingming cao <cmm@...ibm.com>
> >
> > Delayed allocation need to check free blocks at every write time.
> > percpu_counter_read_positive() is not quit accurate
> >  but using percpu_counter_sum_positive() for every write
> > frequently is quite expensive.
> 
> I couldn't compile the latest ext4 patch qeueu.
> 
>   LD      fs/ext3/ext3.o
>   LD      fs/ext3/built-in.o
>   CC      fs/ext4/balloc.o
> fs/ext4/balloc.c: In function ‘ext4_has_free_blocks’:
> fs/ext4/balloc.c:1629: error: implicit declaration of function ‘percpu_counter_sum_positive_set’
> 
> 
> > +		    percpu_counter_sum_positive_set(&sbi->s_freeblocks_counter);
> 
> Maybe the above line which in percpucounter-add-sum-and-set-function.patch
> is percpu_counter_sum_and_set(&sbi->s_freeblocks_couter).
> 

oops. Updated patch queue, please check again.

Mingming
> Thanks,
> Akira Fujita
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html