linux-ext4 - Re: [RFC][PATCH 6/6] delalloc ENOSPC: improve percpu counter accounting accurate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <48435EB8.2070806@rs.jp.nec.com>
Date:	Mon, 02 Jun 2008 11:45:12 +0900
From:	Akira Fujita <a-fujita@...jp.nec.com>
To:	Mingming Cao <cmm@...ibm.com>
CC:	linux-ext4@...r.kernel.org
Subject: Re: [RFC][PATCH 6/6] delalloc ENOSPC: improve percpu	counter	accounting
 accurate

Mingming Cao wrote:
> On Mon, 2008-06-02 at 09:19 +0900, Akira Fujita wrote:
>> Hi,
>>
>>> Mingming Cao wrote:
>>> percpu counter: update center counter when sum per-cpu counter
>>>
>>> From: Mingming cao <cmm@...ibm.com>
>>>
>>> Delayed allocation need to check free blocks at every write time.
>>> percpu_counter_read_positive() is not quit accurate
>>>  but using percpu_counter_sum_positive() for every write
>>> frequently is quite expensive.
>> I couldn't compile the latest ext4 patch qeueu.
>>
>>   LD      fs/ext3/ext3.o
>>   LD      fs/ext3/built-in.o
>>   CC      fs/ext4/balloc.o
>> fs/ext4/balloc.c: In function ‘ext4_has_free_blocks’:
>> fs/ext4/balloc.c:1629: error: implicit declaration of function ‘percpu_counter_sum_positive_set’
>>
>>
>>> +		    percpu_counter_sum_positive_set(&sbi->s_freeblocks_counter);
>> Maybe the above line which in percpucounter-add-sum-and-set-function.patch
>> is percpu_counter_sum_and_set(&sbi->s_freeblocks_couter).
>>
> 
> oops. Updated patch queue, please check again.

I confirmed that I could compile the latest ext4 patch queue correctly.
Thanks.   :-)

Regards,
Akira Fujita
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html