lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 02 Jun 2008 16:03:20 +0100
From:	"Ricardo M. Correia" <Ricardo.M.Correia@....COM>
To:	Karel Zak <kzak@...hat.com>
Cc:	"Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
	Andreas Dilger <adilger@....COM>
Subject: Re: [PATCH e2fsprogs] Add ZFS detection to libblkid

Hi Karel,

On Seg, 2008-06-02 at 09:41 +0200, Karel Zak wrote: 
> It'd be nice to add ZFS detection to libvolume_id from udev package.

Interesting, I didn't know libvolume_id existed.
Is there a reason why there should be 2 different libraries doing what
appears to be essentially the same thing?

> > +	/* read nvpair data for pool name, pool GUID (complex) */
> > +	//blkid_set_tag(probe->dev, "LABEL", pool_name, sizeof(pool_name));
> > +	//set_uuid(probe->dev, pool_guid, 0);
> 
>  C++ ?

Actually, those are valid C99 tokens for comments. I don't see any style
guide in the source of e2fsprogs, and they do appear to be used in some
places (like lib/uuid/uuid_gen_nt.c), but if necessary that can be
easily changed.

> > -		if (memcmp(id->bim_magic, buf + (id->bim_sboff&0x3ff),
> > +		if (memcmp(id->bim_magic, buf + (id->bim_sboff & 0x3ff),
> 
>  ???

That's unrelated to the purpose of this patch, it seems to be just a
style fix (inherited from Andreas' patch) :-)

Thanks,
Ricardo

--

Ricardo Manuel Correia
Lustre Engineering

Sun Microsystems, Inc.
Portugal
Phone +351.214134023 / x58723
Mobile +351.912590825
Email Ricardo.M.Correia@....COM

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists