linux-ext4 - Re: [PATCH] jbd2: If a journal checksum error is detected, propagate the error to ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20080605031712.GK2961@webber.adilger.int>
Date:	Wed, 04 Jun 2008 21:17:12 -0600
From:	Andreas Dilger <adilger@....com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org, Girish.Shilamkar@....com
Subject: Re: [PATCH] jbd2: If a journal checksum error is detected,
	propagate the error to ext4

On Jun 04, 2008  19:56 -0400, Theodore Ts'o wrote:
> If a journal checksum error is detected, the ext4 filesystem will call
> ext4_error(), and the mount will either continue, become a read-only
> mount, or cause a kernel panic based on the superblock flags
> indicating the user's preference of what to do in case of filesystem
> corruption being detected.
> 
> XXX should we simply fail the mount instead in the panic case?

It does seem that if someone has a bad ext4 root filesystem it would be
easy to get an unusable system.  That is why there are no "ext3_error"
or "ext4_error" calls anywhere in ext[34]_fill_super().  They are all
instead "printk(KERN_ERR ...)" and the mount fails.

> diff --git a/scripts/package/Makefile b/scripts/package/Makefile
> index 5e32607..f758b75 100644
> --- a/scripts/package/Makefile
> +++ b/scripts/package/Makefile

Not sure what the rest of this patch is...

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html