linux-ext4 - Re: [PATCH -v2] ext4: Use inode preallocation with -o noextents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080605032220.GC10488@mit.edu>
Date:	Wed, 4 Jun 2008 23:22:20 -0400
From:	Theodore Tso <tytso@....edu>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	cmm@...ibm.com, sandeen@...hat.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH -v2] ext4: Use inode preallocation with -o noextents

when I moved this patch to the beginning of the unstable patch queue,
it didn't apply.  When I tried to look at it, my head started
spinning.  The patch applied to the wrong function, apparently,
because there is so much code duplication "patch" got confused.  I
can't blame it, though, because *I* got confused.  

fs/ext4/balloc.c is a complete disaster right now.  We have:

ext4_new_blocks_old()
ext4_new_meta_block()
ext4_new_meta_blocks()
ext4_new_blocks()

... and without any comments, it is extremely impenetrable.  Someone
needs to document what the heck all of the various functions have to
do with each other, when they get used (i.e., with which mount options). 

Why aren't we factoring out the last three into a single function?  

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html