lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <48652D4D.9010202@redhat.com> Date: Fri, 27 Jun 2008 13:11:25 -0500 From: Eric Sandeen <sandeen@...hat.com> To: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com> CC: cmm@...ibm.com, tytso@....edu, jack@...e.cz, linux-ext4@...r.kernel.org Subject: Re: [PATCH] jbd2: We shouldnot cap writeback when we are doing a journal commit Aneesh Kumar K.V wrote: > A journal commit need to make sure we submit data buffers before > we submit the meta-data buffers in ordered mode. We should > not be looking at BDI_CAP_NO_WRITEBACK when doing a journal commit. > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com> and I don't think we'll ever even see that flag set... Acked-by: Eric Sandeen <sandeen@...hat.com> > --- > fs/jbd2/commit.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c > index 32ca3c3..f8b3be8 100644 > --- a/fs/jbd2/commit.c > +++ b/fs/jbd2/commit.c > @@ -203,9 +203,6 @@ static int journal_submit_inode_data_buffers(struct address_space *mapping) > .for_writepages = 1, > }; > > - if (!mapping_cap_writeback_dirty(mapping)) > - return 0; > - > ret = generic_writepages(mapping, &wbc); > return ret; > } -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists