lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 27 Jun 2008 23:04:39 +0200
From:	Jan Kara <jack@...e.cz>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	cmm@...ibm.com, tytso@....edu, jack@...e.cz,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] jbd2: We shouldnot cap writeback when we are doing a
	journal commit

On Fri 27-06-08 13:11:25, Eric Sandeen wrote:
> Aneesh Kumar K.V wrote:
> > A journal commit need to make sure we submit data buffers before
> > we submit the meta-data buffers in ordered mode. We should
> > not be looking at BDI_CAP_NO_WRITEBACK when doing a journal commit.
> > 
> > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
> 
> and I don't think we'll ever even see that flag set...
> 
> Acked-by: Eric Sandeen <sandeen@...hat.com>
  Yes, I also don't think it really matters :). So feel free to remove that
check.

								Honza
> 
> > ---
> >  fs/jbd2/commit.c |    3 ---
> >  1 files changed, 0 insertions(+), 3 deletions(-)
> > 
> > diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
> > index 32ca3c3..f8b3be8 100644
> > --- a/fs/jbd2/commit.c
> > +++ b/fs/jbd2/commit.c
> > @@ -203,9 +203,6 @@ static int journal_submit_inode_data_buffers(struct address_space *mapping)
> >  		.for_writepages = 1,
> >  	};
> >  
> > -	if (!mapping_cap_writeback_dirty(mapping))
> > -		return 0;
> > -
> >  	ret = generic_writepages(mapping, &wbc);
> >  	return ret;
> >  }
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists