linux-ext4 - Re: [PATCH 01/15][e2fsprogs] libext2fs: Add 64-bit support to the undo manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080716132628.GS8185@mit.edu>
Date:	Wed, 16 Jul 2008 09:26:28 -0400
From:	Theodore Tso <tytso@....edu>
To:	Goswin von Brederlow <goswin-v-b@....de>
Cc:	"Jose R. Santos" <jrs@...ibm.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 01/15][e2fsprogs] libext2fs: Add 64-bit support to the
	undo manager

On Wed, Jul 16, 2008 at 01:16:58PM +0200, Goswin von Brederlow wrote:
> Why not this?
> 
> +static errcode_t undo_read_blk64(io_channel channel, blk64_t block,
> +				 int count, void *data);
> 
> libext2fs specifically has blk_t and blk64_t types to represent a
> block. Why not use them? It is less to type and easier to read.

It's an abstraction layer thing.  blk64_t is defined in ext2fs.h, and
the io_managers don't include it.  The I/O managers are a small amount
of code, and it hasn't been worth it to explicitly define a type just
for them in the header file.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html