linux-ext4 - Re: Add ext4__allow_read-only_mounts_with_corrupted_block_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080716133407.GT8185@mit.edu>
Date:	Wed, 16 Jul 2008 09:34:07 -0400
From:	Theodore Tso <tytso@....edu>
To:	Andreas Dilger <adilger@....com>
Cc:	Gary Hawco <ghawco@....net>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: Add
	ext4__allow_read-only_mounts_with_corrupted_block_group_checksums
	patch

On Wed, Jul 16, 2008 at 03:29:14AM -0600, Andreas Dilger wrote:
> > Rebooted and e2fsck saw errors and did a forced fsck without having to
> > reboot. All is well thus far.
> 
> You shouldn't really have rebooted at that point, just run e2fsck on
> the filesystem to clear the checksums.

This was the root filesystem so he couldn't have run e2fsck on the
mounted filesystem.

> > Then I did the reverse: tune2fs -O uninit_bg /dev/sda6 to renable uninit_bg
> > feature.  Again, I was prompted to run e2fsck on system.
> 
> Again, you should have just run e2fsck on the filesystem without rebooting,
> in order to update the checksums.

Ditto.

> > I was under the impression that the newest patch would handle this or am I
> > mistaken?
> 
> We probably need to allow the kernel to mount the filesystem read-only in
> this case in order to run e2fsck.

That's what the patch I added in the latest snapshot was supposed to
do.  I admit I haven't had a chance to test it yet, but the code looks
like it should do the right thing.  You are sure that you are mounting
the root filesystem read/only (there is "ro" on the boot command line)
and this is the kernel with this patch applied, right?

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html