linux-ext4 - Re: [PATCH, RFC] ext4: flex_bg ialloc, don't pick "best

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080816152541.GB8422@mit.edu>
Date:	Sat, 16 Aug 2008 11:25:41 -0400
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	"Jose R. Santos" <jrs@...ibm.com>
Subject: Re: [PATCH, RFC] ext4: flex_bg ialloc, don't pick "best_flex" with
	0 inodes

On Fri, Aug 15, 2008 at 05:01:10PM -0500, Eric Sandeen wrote:
> It seems like adjusting the following test is a better plan;
> for starters I do not see that best_flex can ever be < 0, so

Given that ext4_group_t is an unsigned long, that's certainly true.
:-)

> that test is replaced, and if the current "best" flex group
> has no inodes free, and the current one does have room,
> it is promoted to the next "best."

Looks good to me.  I've added it to the patch queue.

> Signed-of-by: Eric Sandeen <sandeen@...hat.com>

(forgot an 'f' :-)

Signed-off-by: "Theodore Ts'o" <tytso@....edu>

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html