[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <48CD7FC3.4050807@redhat.com>
Date: Sun, 14 Sep 2008 14:18:59 -0700
From: Eric Sandeen <sandeen@...hat.com>
To: ext4 development <linux-ext4@...r.kernel.org>
Subject: [PATCH] properly show journal checksum/async options
The journal_checksum option is not being displayed in
/proc/mounts ... add this to the show_options() output, but
only if journal_async_commit is not specified, as that enables
journal_checksum internally.
Signed-off-by: Eric Sandeen <sandeen@...hat.com>
---
(Aside: this reminds me that we only show non-default options
in show_options; has there been any discussion of whether
these should be defaults?)
Index: linux-2.6/fs/ext4/super.c
===================================================================
--- linux-2.6.orig/fs/ext4/super.c 2008-09-14 16:12:54.898077064 -0500
+++ linux-2.6/fs/ext4/super.c 2008-09-14 16:13:22.878077407 -0500
@@ -746,8 +746,12 @@ static int ext4_show_options(struct seq_
*/
seq_puts(seq, ",barrier=");
seq_puts(seq, test_opt(sb, BARRIER) ? "1" : "0");
+ /* journal_async_commit enables journal_checksum internally */
if (test_opt(sb, JOURNAL_ASYNC_COMMIT))
seq_puts(seq, ",journal_async_commit");
+ else if (test_opt(sb, JOURNAL_CHECKSUM))
+ seq_puts(seq, ",journal_checksum");
+
if (test_opt(sb, NOBH))
seq_puts(seq, ",nobh");
if (!test_opt(sb, EXTENTS))
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists