linux-ext4 - Re: [PATCH] properly show journal checksum/async options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080920220647.GA9088@mit.edu>
Date:	Sat, 20 Sep 2008 18:06:47 -0400
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] properly show journal checksum/async options

On Sun, Sep 14, 2008 at 02:18:59PM -0700, Eric Sandeen wrote:
> The journal_checksum option is not being displayed in
> /proc/mounts ... add this to the show_options() output, but
> only if journal_async_commit is not specified, as that enables
> journal_checksum internally.
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Acked-by: "Theodore Ts'o" <tytso@....edu>

I'll add it to the patch queue, probably combined with a patch to add
journal_sync_commit, and with a patch to make journal_async_commit the
default.

> (Aside: this reminds me that we only show non-default options
> in show_options; has there been any discussion of whether
> these should be defaults?)

Good point, thanks for raising the question.

The reason why journal_async_commit wasn't turned on by default
originally was because e2fsck didn't have support for journal
checksums before e2fsprogs 1.41.0.  At this point, it seems like
turning on async_commit is the obvious (and performant) thing to do;
any objections?

	    				- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html