linux-ext4 - Re: [PATCH] EXT4: Avoid double dirtying of super block in ext4_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081006233949.GB9337@mit.edu>
Date:	Mon, 6 Oct 2008 19:39:49 -0400
From:	Theodore Tso <tytso@....edu>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] EXT4: Avoid double dirtying of super block in
	ext4_put_super()

On Mon, Oct 06, 2008 at 11:21:18PM +0200, Andi Kleen wrote:
> EXT4: Avoid double dirtying of super block in ext4_put_super()
> 
> While reading code I noticed that ext4_put_super() dirties the 
> superblock bh twice. It is always done in ext4_commit_super()
> too. Remove the redundant dirty operation.
> 
> Should be a nop semantically.
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>

As it turns out, I had taken out the mark_buffer_dirty as superfluous
in the following patch:

    ext4/jbd2: Avoid WARN() messages when failing to write to the superblock

(This was Arjan's favorite ext3/ext4 top-ten kerneloops.org bug).

However I didn't kill the BUFFER_TRACE(sbi->s_sbh, "marking dirty");
line, which should have been deleted too.  I'll take out the change
from my patch since it's really unrelated to fixing the kerneloops.org
WARN'ing, and take your patch and it include it for submission to
Linus in the ext3 tree.

Thanks,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html