linux-ext4 - Re: [PATCH 1/6] ext4: Add blocks added during resize to bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081103023344.GR8134@mit.edu>
Date:	Sun, 2 Nov 2008 21:33:44 -0500
From:	Theodore Tso <tytso@....edu>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	cmm@...ibm.com, sandeen@...hat.com, frederic.bohe@...l.net,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/6] ext4: Add blocks added during resize to bitmap

On Fri, Oct 31, 2008 at 10:20:54PM +0530, Aneesh Kumar K.V wrote:
> With this change new blocks added during resize
> are marked as free in the block bitmap and the
> group is flagged with EXT4_GROUP_INFO_NEED_INIT_BIT
> flag. This make sure when mballoc tries to allocate
> blocks from the new group we would reload the
> buddy information using the bitmap present in the disk.

My comment about why not use ext4_mb_free_blocks() still applies.
Also, if you're going to replace a patch, please put V2 (or Vn+1) in
the subject like.  I wasted time dealing with your earlier set of
three resize patches since I didn't realize they were replicated in
this six patch series.

Also, Patch 2 of 6 didn't apply as of 2.6.28-rc3.  I fixed it up in
the patch queue, but please check it.

Thanks!!

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html