[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081121175110.GA12412@infradead.org>
Date: Fri, 21 Nov 2008 12:51:10 -0500
From: Christoph Hellwig <hch@...radead.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc: cmm@...ibm.com, tytso@....edu, sandeen@...hat.com,
linux-ext4@...r.kernel.org
Subject: Re: [PATCH -V4] ext4: sparse fixes
On Fri, Nov 21, 2008 at 10:10:36PM +0530, Aneesh Kumar K.V wrote:
> #define EXT4_HAS_COMPAT_FEATURE(sb,mask) \
> - (EXT4_SB(sb)->s_es->s_feature_compat & cpu_to_le32(mask))
> + (__force __u32)!!(EXT4_SB(sb)->s_es->s_feature_compat & \
> + cpu_to_le32(mask))
As mentioned before please don't abuse __force here.
((EXT4_SB(sb)->s_es->s_feature_compat & cpu_to_le32(mask)) != 0)
does the right things and is a lote more readable.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists