linux-ext4 - Re: [PATCH -V4] ext4: sparse fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081121175534.GI11212@skywalker>
Date:	Fri, 21 Nov 2008 23:25:34 +0530
From:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	cmm@...ibm.com, tytso@....edu, sandeen@...hat.com,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH -V4] ext4: sparse fixes

On Fri, Nov 21, 2008 at 12:51:10PM -0500, Christoph Hellwig wrote:
> On Fri, Nov 21, 2008 at 10:10:36PM +0530, Aneesh Kumar K.V wrote:
> >  #define EXT4_HAS_COMPAT_FEATURE(sb,mask)			\
> > -	(EXT4_SB(sb)->s_es->s_feature_compat & cpu_to_le32(mask))
> > +	(__force __u32)!!(EXT4_SB(sb)->s_es->s_feature_compat &	\
> > +					cpu_to_le32(mask))
> 
> As mentioned before please don't abuse __force here.
> 
> 	((EXT4_SB(sb)->s_es->s_feature_compat & cpu_to_le32(mask)) != 0)
> 
> does the right things and is a lote more readable.

I thought your comment was on returning value that had multiple flag bit
set. I didn't look at the __force usage as bad. I will send an updated patch.

-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html