linux-ext4 - Re: [PATCH]ext4: fix s_dirty_blocks_counter if block allocation failed with nodelalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081201103641.GA13242@skywalker>
Date:	Mon, 1 Dec 2008 16:06:41 +0530
From:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	Akira Fujita <a-fujita@...jp.nec.com>
Cc:	Theodore Tso <tytso@....edu>, Li Zefan <lizf@...fujitsu.com>,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH]ext4: fix s_dirty_blocks_counter if block allocation
	failed with nodelalloc

On Mon, Dec 01, 2008 at 07:21:54PM +0900, Akira Fujita wrote:
> ext4: Fix s_dirty_blocks_counter if block allocation failed with nodelalloc
> 
> From: Akira Fujita <a-fujita@...jp.nec.com>
> 
> If block allocation failed after marking claimed blocks as dirty blocks
> with nodelalloc, we have to subtract these blocks from
> s_dirty_blocks_counter in error handling.
> Otherwise s_dirty_blocks_counter goes wrong so that
> filesystem's free blocks decreases incorrectly.

Why did the block allocation fail ? With delayed allocation ENOSPC
should not happen during block allocation. That would mean we did
something wrong in block reservation.

> 
> This issue was reported as ext4 online defrag's bug by Li Zefan.
> http://marc.info/?l=linux-ext4&m=122697235715170&w=2

-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html