linux-ext4 - Re: [PATCH]ext4: fix s_dirty_blocks_counter if block allocation failed with nodelalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <493731FD.5040809@rs.jp.nec.com>
Date:	Thu, 04 Dec 2008 10:27:25 +0900
From:	Akira Fujita <a-fujita@...jp.nec.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
CC:	Theodore Tso <tytso@....edu>, Li Zefan <lizf@...fujitsu.com>,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH]ext4: fix s_dirty_blocks_counter if block allocation	failed
 with nodelalloc


Hi Aneesh,
Aneesh Kumar K.V wrote:
> On Mon, Dec 01, 2008 at 07:21:54PM +0900, Akira Fujita wrote:
>> ext4: Fix s_dirty_blocks_counter if block allocation failed with nodelalloc
>>
>> From: Akira Fujita <a-fujita@...jp.nec.com>
>>
>> If block allocation failed after marking claimed blocks as dirty blocks
>> with nodelalloc, we have to subtract these blocks from
>> s_dirty_blocks_counter in error handling.
>> Otherwise s_dirty_blocks_counter goes wrong so that
>> filesystem's free blocks decreases incorrectly.
> 
> Why did the block allocation fail ? With delayed allocation ENOSPC
> should not happen during block allocation. That would mean we did
> something wrong in block reservation.

My case was *nodelalloc* and FS was almost full.
This problem occurs in multiple defrag running in short time.
Usually defrag releases temporary inode's blocks with iput,
then FS free blocks are recover but contiguous blocks do not recover
until next journal commit.
so we can not re-use contiguous blocks immediately.
There are enough free blocks in FS so that
ext4_claim_free_blocks marks claimed blocks as dirty,
but ext4_regular_allocator can not find enough blocks,
so mb_new_blocks returns ENOSPC without decreasing dirty blocks.

Regards,
Akira Fujita

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html