linux-ext4 - Re: [PATCH 5/6] [64-bit] (blk_t) cast in ext2fs_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 4 May 2009 02:21:24 -0400
From:	Valerie Aurora <vaurora@...hat.com>
To:	Nick Dokos <nicholas.dokos@...com>
Cc:	linux-ext4@...r.kernel.org, "Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH 5/6] [64-bit] (blk_t) cast in ext2fs_new_block2()

On Fri, May 01, 2009 at 04:47:17AM -0400, Nick Dokos wrote:
> Found by code inspection after similar gratuitous cast in
> ext2fs_get_free_blocks2() (first patch in this series).
> 
> Signed-off-by: Nick Dokos <nicholas.dokos@...com>
> ---
>  lib/ext2fs/alloc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/ext2fs/alloc.c b/lib/ext2fs/alloc.c
> index 9f11673..a7c8860 100644
> --- a/lib/ext2fs/alloc.c
> +++ b/lib/ext2fs/alloc.c
> @@ -170,7 +170,7 @@ errcode_t ext2fs_new_block2(ext2_filsys fs, blk64_t goal,
>  					   (i - fs->super->s_first_data_block) /
>  					   EXT2_BLOCKS_PER_GROUP(fs->super));
>  
> -		if (!ext2fs_fast_test_block_bitmap2(map, (blk_t) i)) {
> +		if (!ext2fs_fast_test_block_bitmap2(map, i)) {
>  			*ret = i;
>  			return 0;
>  		}
> -- 
> 1.6.0.6
> 

Signed-off-by: Valerie Aurora (Henson) <vaurora@...hat.com>

-VAL
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html