linux-ext4 - Re: [PATCH] EXT3: Change all super.c messages to print the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A130022.6090807@redhat.com>
Date:	Tue, 19 May 2009 13:53:22 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Theodore Tso <tytso@....edu>
CC:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH] EXT3: Change all super.c messages to print the device

Theodore Tso wrote:
> On Tue, May 19, 2009 at 07:14:30PM +0200, Jan Kara wrote:
>>> EXT3: Change all super.c messages to print the device
>>>
>>> I had a problem where it was unclear to which device a ext3 message belonged.
>>> Not all of them them print it.
>>>
>>> This patch changes ext3 super.c to include the device name with all 
>>> warning/error messages, by using a new utility function ext3_msg. 
>>> It's a rather large patch, but very mechanic. I left debug printks
>>> alone.
>>>
>>> The normal mount output looks a little more regular now because near all
>>> messages are in the same format.
>>>
>>> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
>>   Ted, did you pick up this cleanup? I don't see any reply or the patch
>> being merged... The cleanup looks nice.
> 
> No, I didn't but thanks for reminding me; I agree it's a good cleanup.
> We should get it ported over to ext4, too.

I'll do that, unless anyone's already started.

There's a bit of inconsistency in the patch between:

ext3_msg(sb, KERN_ERR "message");
and
ext3_msg(sb, KERN_ERR, "message");

just FWIW.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html