linux-ext4 - Re: [PATCH] EXT3: Change all super.c messages to print the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090520112108.GA24836@mit.edu>
Date:	Wed, 20 May 2009 07:21:08 -0400
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH] EXT3: Change all super.c messages to print the device

On Tue, May 19, 2009 at 01:53:22PM -0500, Eric Sandeen wrote:
> > No, I didn't but thanks for reminding me; I agree it's a good cleanup.
> > We should get it ported over to ext4, too.
> 
> I'll do that, unless anyone's already started.

If you would, that would be great.

> There's a bit of inconsistency in the patch between:
> 
> ext3_msg(sb, KERN_ERR "message");
> and
> ext3_msg(sb, KERN_ERR, "message");

Obviously the second is what is preferred.  :-)

If you have a chance, could you clean up Andi's patch and resend it?
I have one or two minor ext3 fixups in the ext4 tree, but we should
check and make sure Andrew isn't carrying anything major in his mmotm
tree, so as to avoid patch collisions.

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html