linux-ext4 - Re: [PATCH 1/3] xfstests: basic fallocate boundary tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090621191657.GA19596@infradead.org>
Date:	Sun, 21 Jun 2009 15:16:57 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Eric Sandeen <sandeen@...deen.net>
Cc:	Christoph Hellwig <hch@...radead.org>,
	ext4 development <linux-ext4@...r.kernel.org>,
	xfs-oss <xfs@....sgi.com>
Subject: Re: [PATCH 1/3] xfstests: basic fallocate boundary tests

On Sat, Jun 20, 2009 at 04:33:55PM -0500, Eric Sandeen wrote:
> hmm this is really testing that xfs_io in particular has fallocate...
> so maybe like this?
> 
> diff --git a/common.rc b/common.rc
> index 39350b3..55aecd6 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -704,6 +704,18 @@ _require_user()
>      [ "$?" == "0" ] || _notrun "$qa_user user not defined."
>  }
>  
> +# check that xfs_io, glibc, kernel, and filesystem all (!) support
> +# fallocate
> +#
> +_require_xfs_io_falloc()
> +	testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $TEST_DIR/$tmp.io 2>&1`
> +	rm -f $TEST_DIR/$tmp.io 2>&1 > /dev/null
> +	echo $testio | grep -q "not found" && \
> +		_notrun "xfs_io fallocate support is missing"
> +	echo $testio | grep -q "Operation not supported" && \
> +		_notrun "xfs_io fallocate command failed (old kernel/wrong fs?)"
> +}

Looks good,


Reviewed-by: Christoph Hellwig <hch@....de>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html