linux-ext4 - jbd: a question on __log_wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Aug 2009 13:31:06 +0900
From:	홍신 shin hong <hongshin@...il.com>
To:	linux-ext4@...r.kernel.org
Subject: jbd: a question on __log_wait_for_space()

Hi. I have a question on __log_wait_for_space() in jbd/checkpoint.c
while I read jbd code of Linux 2.6.30.4

In __log_wait_for_space(), it releases and re-takes journal->j_state_lock
in while loop (at line 139).

After the retaking the lock, it checks 'space_left < nblocks'. It seems that
it considers that the journal might be written during the lock
releasing and re-taking.

Then, is it necessary to check 'journal->j_flags & JFS_ABORT' again too?
I found that journal_t's j_flags is synchronized via j_state_lock. So, is there
any possiblity that j_flags value can be changed during the lock
releasing and re-taking?

Thank you

Sincerely
Shin Hong
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html