linux-ext4 - Re: [PATCH] e2fsprogs: remove misleading argument from ext2fs_bg_flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20090903051235.GL4197@webber.adilger.int>
Date:	Wed, 02 Sep 2009 23:12:35 -0600
From:	Andreas Dilger <adilger@....com>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	Theodore Tso <tytso@....edu>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2fsprogs: remove misleading argument from
	ext2fs_bg_flags_clear

On Sep 02, 2009  22:00 -0500, Eric Sandeen wrote:
> What about perhaps just these 3:
>
> ext2fs_bg_flags_zero(fs, group) /* zeros bg_flags */
>
> ext2fs_bg_flags_set(fs, group, flags) /* adds flags to bg_flags */
> ext2fs_bg_flags_clear(fs, group, flags) /* clears flags in bg_flags */
>
> and remove the original ext2fs_bg_flags_set / ext2fs_bg_flags_clear.

Yes, this is exactly what I would expect from this kind of interface.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html