linux-ext4 - Re: [PATCH] Fix ext2fs_set_gdt_csum() to use access functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A9F5050.1010702@redhat.com>
Date:	Thu, 03 Sep 2009 00:12:48 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	nicholas.dokos@...com
CC:	Theodore Ts'o <tytso@....edu>, linux-ext4@...r.kernel.org,
	Andreas Dilger <adilger@....com>,
	Justin Maggard <jmaggard10@...il.com>,
	Ric Wheeler <rwheeler@...hat.com>
Subject: Re: [PATCH] Fix ext2fs_set_gdt_csum() to use access functions.

Nick Dokos wrote:
> Eric Sandeen <sandeen@...hat.com> wrote:
> 
>>> Replace all field accesses with calls to access functions.
>>> Most importantly, get rid of the mis-declared group descriptor
>>> pointer which caused the wrong fields to be updated.
>> Not quite sure what you mean by this?  It worked ok for the "old" size ...
>>
> 
> Yes, it worked fine for the old ext2_group_desc structure, but it has no
> hope of working with the ext4_group_desc: the sizes are different, so
> doing bg++ gets it pointing somewhere within the first descriptor, not
> to the beginning of the second. That's how it ended up modifying
> reserved fields.

right.  Ok, I was just confused when you said "mis-declared" - thought 
you meant something was wrong with how bg was set or initialized.

> Sorry about the whitespace problems.  As for the flags, I didn't worry
> too much about how to set them: I figured that once the dust settles,
> we'll follow the proper convention.

sounds good.

Thanks,
-Eric

> Thanks for looking it over and testing too! We'll see whether Justin's
> problem disappears.
> 
> Nick

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html