[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091004022952.GE15688@mit.edu>
Date: Sat, 3 Oct 2009 22:29:52 -0400
From: Theodore Tso <tytso@....edu>
To: Peng Tao <bergwolf@...il.com>
Cc: linux-ext4@...r.kernel.org
Subject: Re: [PATCH] blkid/Makefile.in: ignore rmdir non-empty dir error
On Mon, Sep 28, 2009 at 06:57:22PM +0800, Peng Tao wrote:
> checker/* blkid_types.h ../libblkid.a ../libblkid_p.a \
> $(SMANPAGES) blkid
> - -rmdir tests
> + -rmdir --ignore-fail-on-non-empty tests
>
Sorry, NACK. This will blow up on systems that aren't using the GNU
shellutils. The error is ignored, which is good enough. We can do
something like this instead:
@echo rmdir tests/tmp tests
-@...ir tests/tmp tests >& /dev/null
If we really care, I suppose.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists