linux-ext4 - Re: [PATCH] blkid/Makefile.in: ignore rmdir non-empty dir error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091004024725.GG15688@mit.edu>
Date:	Sat, 3 Oct 2009 22:47:25 -0400
From:	Theodore Tso <tytso@....edu>
To:	Peng Tao <bergwolf@...il.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] blkid/Makefile.in: ignore rmdir non-empty dir error

On Mon, Sep 28, 2009 at 06:57:22PM +0800, Peng Tao wrote:
> Otherwise, make clean returns the following error, which is missleading.
> rmdir tests
> rmdir: failed to remove `tests': Directory not empty
> make: [clean] Error 1 (ignored)
> 
> Signed-off-by: Peng Tao <bergwolf@...il.com>

This is what I checked in instead.

					- Ted

commit 7822f784f1edf767cc74044e02702a6d44cee267
Author: Theodore Ts'o <tytso@....edu>
Date:   Sat Oct 3 22:33:47 2009 -0400

    blkid: Avoid a potentially error message when running "make clean"
    
    This error isn't terribly important, but apparently it causes some
    users/developers distress.
    
    Signed-off-by: "Theodore Ts'o" <tytso@....edu>

diff --git a/lib/blkid/Makefile.in b/lib/blkid/Makefile.in
index 9169226..9339718 100644
--- a/lib/blkid/Makefile.in
+++ b/lib/blkid/Makefile.in
@@ -181,7 +181,8 @@ clean::
 		tests/*.img results test_probe core profiled/* \
 		checker/* blkid_types.h ../libblkid.a ../libblkid_p.a \
 		$(SMANPAGES) blkid
-	-rmdir tests
+	@echo rmdir tests/tmp tests
+	@(rmdir tests/tmp tests 2> /dev/null ; exit 0)
 
 mostlyclean:: clean
 distclean:: clean


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html