linux-ext4 - question about ext4/inode.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0911021708550.2115@ask.diku.dk>
Date:	Mon, 2 Nov 2009 17:10:46 +0100 (CET)
From:	Julia Lawall <julia@...u.dk>
To:	tytso@....edu, adilger@....com, linux-ext4@...r.kernel.org
Subject: question about ext4/inode.c

The function ext4_da_writepages_trans_blocks contains the following code:

        if (!(inode->i_flags & EXT4_EXTENTS_FL) &&
            (max_blocks > EXT4_MAX_TRANS_DATA))
                max_blocks = EXT4_MAX_TRANS_DATA;


Elsewhere the constant EXT4_EXTENTS_FL is used as follows:

EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL

Should that be done in ext4_da_writepages_trans_blocks as well?

thanks,
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html