linux-ext4 - Re: journaled quota file question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091102123124.GA23161@duck.suse.cz>
Date:	Mon, 2 Nov 2009 13:31:24 +0100
From:	Jan Kara <jack@...e.cz>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: journaled quota file question

  Hi,

On Sat 31-10-09 21:59:44, Dmitry Monakhov wrote:
> Dmitry Monakhov <dmonakhov@...nvz.org> writes:
> 
> > While looking to ext3/4 quota code I'm wondering
> > Why do we have to place journaled quota file on fs root?
> > In some situations it may be useful to place it deeper for example:
> > /root/dir/quota_file
> > The only reason what comes in to my mind is that some one
> > may rename parent folder rename("/root/dir", "/root/dir2")
> > Is this the only reason?
  Well, the reason is that we have to read & write the files during orphan
recovery on mount. A that time the filesystem is not fully set up so you
cannot use VFS directory traversal code and I didn't want to implement
ext[34] specific one. Also as you write above, if you have quota files in
some subdirectory, there are more possibilities for failure.
  Admittedly, I don't see a big point in having quota files in some other
directory. In fact, they should rather be system files not visible in
any directory but that requires rather non-trivial changes to repquota and
moving quotacheck functionality to fsck and I never got to doing that.

> add an author in cc:
  Thanks.

									Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html