linux-ext4 - Re: [PATCH 04/27] ext2: Add ext2_sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091102102654.GG31511@one.firstfloor.org>
Date:	Mon, 2 Nov 2009 11:26:54 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Jan Blunck <jblunck@...e.de>
Cc:	linux-fsdevel@...r.kernel.org, Matthew Wilcox <matthew@....cx>,
	linux-kernel@...r.kernel.org, Andi Kleen <andi@...stfloor.org>,
	Jan Kara <jack@...e.cz>, Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@...ux.intel.com>,
	Christoph Hellwig <hch@....de>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Andreas Dilger <adilger@....com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 04/27] ext2: Add ext2_sb_info mutex

> @@ -762,6 +767,12 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
>  	sbi->s_sb_block = sb_block;
>  
>  	/*
> +	 * mutex for protection of modifications of the superblock while being
> +	 * write out by ext2_write_super() or ext2_sync_fs().
> +	 */
> +	mutex_init(&sbi->s_mutex);

I didn't go over all the code paths in detail, but if you replace
the BKL with a mutex that is hold over a longer write-out sleep
period you potentially limit IO parallelism a lot.

In this case since the BKL didn't protect over the sleep anyways it might
be reasonable to drop it during the IO operation (and possibly if
you're sure nothing else sleeps use a spin lock)

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html