linux-ext4 - Re: [PATCH 4/4 v2] Fix direct IO return values over fullfilled fallocate space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091104022707.GI6510@mit.edu>
Date:	Tue, 3 Nov 2009 21:27:07 -0500
From:	Theodore Tso <tytso@....edu>
To:	Mingming <cmm@...ibm.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	Curt Wohlgemuth <curtw@...gle.com>
Subject: Re: [PATCH 4/4 v2] Fix direct IO return values over fullfilled
	fallocate space

On Thu, Oct 08, 2009 at 06:13:12PM -0700, Mingming wrote:
> @@ -2827,8 +2828,8 @@ static int ext4_split_unwritten_extents(
>   	 * the size of extent to write, there is no need to split
>   	 * uninitialized extent
>   	 */
> - 	if (allocated <= max_blocks)
> -		return ret;
> + 	if (iblock == ee_block && allocated <= max_blocks)
> +		return allocated;

The change to add "iblock == ee_block" isn't explained in the patch
description and it makes the comment above the conditional no longer
accurate.

Can you add an explanation why it's necessary?

Thanks,
					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html