linux-ext4 - Re: [PATCH] resize2fs: exit fix_sb_journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091113004729.GC32122@mit.edu>
Date:	Thu, 12 Nov 2009 19:47:29 -0500
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	mjevans1983@...il.com
Subject: Re: [PATCH] resize2fs: exit fix_sb_journal_backup early for
	external journal

On Mon, Nov 09, 2009 at 02:57:04PM -0600, Eric Sandeen wrote:
> Resizing a filesystem with an external journal fails when it tries
> to read inode 0:
> 
> # touch testfs
> # truncate testfs 1342177280
> # touch testjournal
> # truncate testjournal 134217728
> # mke2fs -O journal_dev testjournal 
> # losetup /dev/loop0 testjournal 
> # mkfs.ext4 -J device=/dev/loop0 testfs 127680
> # resize2fs testfs 
> resize2fs 1.41.9 (22-Aug-2009)
> Resizing the filesystem on testfs to 327680 (4k) blocks.
> resize2fs: Illegal inode number while trying to resize testfs
> Please run 'e2fsck -fy testfs' to fix the filesystem
> after the aborted resize operation.
> 
> I think the right, simple thing to do is just bail out early
> for an external journal here, as there are no backup blocks
> to update.
> 
> Reported-by: mjevans1983@...il.com
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Thanks, applied to the e2fsprogs maint branch.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html